feat(compreface): support config reload#1271
Merged
roflcoopter merged 1 commit intodevfrom Mar 6, 2026
Merged
Conversation
✅ Deploy Preview for viseron canceled.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the CompreFace face recognition integration to better support configuration reloads, primarily by adding an explicit component unload path and tightening typing/import patterns to reduce runtime import overhead and improve clarity.
Changes:
- Add
unload(vis)to thecomprefacecomponent to clean upvis.dataon component unload/reload. - Make
AbstractFaceRecognition.__init__’sgenerate_entitieskeyword-only and update CompreFace accordingly. - Type-hint and import hygiene improvements (move runtime-unneeded imports under
TYPE_CHECKING, add/adjust return annotations, switch toLOGGER.exception).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| viseron/domains/face_recognition/binary_sensor.py | Minor typing/formatting cleanup for entity attributes. |
| viseron/domains/face_recognition/init.py | Make generate_entities keyword-only; typing improvements and TYPE_CHECKING import moves. |
| viseron/components/compreface/face_recognition.py | Update for new generate_entities calling style; entity registration args aligned with face_recognition domain; improved exception logging and typing/import hygiene. |
| viseron/components/compreface/init.py | Add component unload() implementation and minor iteration simplification for camera identifiers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.